linux-kernel - Re: [PATCH] staging: media: remove unused VIDEO_ATOMISP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vf9aK3V=0+2ZPpA5K7ey2tR930ZFKt+e+FJxJvgPB54Vw@mail.gmail.com>
Date:   Tue, 23 Jan 2018 19:31:27 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Corentin Labbe <clabbe@...libre.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>
Subject: Re: [PATCH] staging: media: remove unused VIDEO_ATOMISP_OV8858 kconfig

On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe <clabbe@...libre.com> wrote:
> Nothing in kernel use VIDEO_ATOMISP_OV8858 since commit 3a81c7660f80 ("media: staging: atomisp: Remove IMX sensor support")
> Lets remove this kconfig option.

First of all, I hardly understand how that change is related.
Second, did you check Makefile?
Third, the files are in the folder (for OV8858).

Taking all above into account, it seems NACK, though regression might
be made by renaming patch from Sakari (no, it's not).
So, it looks like it was never enabled in the first place.

Anyway, do you have hardware to test? This is *most* important reason
why to accept or decline a change to the driver.

-- 
With Best Regards,
Andy Shevchenko