linux-kernel - Re: [PATCH 02/24] objtool: Add retpoline validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180123182126.nuwbxppfqmzrzu4i@pd.tnic>
Date:   Tue, 23 Jan 2018 19:21:26 +0100
From:   Borislav Petkov <bp@...en8.de>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     David Woodhouse <dwmw2@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        linux-kernel@...r.kernel.org, Dave Hansen <dave.hansen@...el.com>,
        Ashok Raj <ashok.raj@...el.com>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Arjan Van De Ven <arjan.van.de.ven@...el.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Jun Nakajima <jun.nakajima@...el.com>,
        Asit Mallick <asit.k.mallick@...el.com>,
        Jason Baron <jbaron@...mai.com>
Subject: Re: [PATCH 02/24] objtool: Add retpoline validation

On Tue, Jan 23, 2018 at 04:25:41PM +0100, Peter Zijlstra wrote:
> David requested a objtool validation pass for RETPOLINE enabled
> builds, where it validates no unannotated indirect  jumps or calls are
> left.
> 
> Add an additional .discard.retpoline_safe section to allow annotating
> the few indirect sites that are required and safe.
> 
> Requested-by: David Woodhouse <dwmw2@...radead.org>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@...radead.org>
> ---
>  scripts/Makefile.build        |    4 +
>  tools/objtool/builtin-check.c |    3 -
>  tools/objtool/builtin.h       |    2 
>  tools/objtool/check.c         |   87 ++++++++++++++++++++++++++++++++++++++++--
>  tools/objtool/check.h         |    1 
>  5 files changed, 92 insertions(+), 5 deletions(-)

Yap, very noisy:

$ grep indirect build.log | wc -l
12904

Let's see how many will remain at the end of the patchset. :)

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.