linux-kernel - Re: [PATCH v6 00/41] ARM: davinci: convert to common clock framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f28601f6-d6f1-9a55-f3cf-62543412bd36@lechnology.com>
Date:   Tue, 23 Jan 2018 14:05:22 -0600
From:   David Lechner <david@...hnology.com>
To:     Bartosz Golaszewski <brgl@...ev.pl>
Cc:     Adam Ford <aford173@...il.com>, linux-clk@...r.kernel.org,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...eaurora.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Sekhar Nori <nsekhar@...com>,
        Kevin Hilman <khilman@...nel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v6 00/41] ARM: davinci: convert to common clock framework

On 01/23/2018 02:01 PM, David Lechner wrote:
> On 01/23/2018 01:53 PM, Bartosz Golaszewski wrote:
>>
>> In the mdio case - the problem is that devm_clk_get() doesn't fail,
>> but somehow the clock doesn't end up in the list of the device's
>> clocks - which is why it's not enabled by pm_runtime_get_sync().
>>
> 
> 
> Right. This is because devm_clk_get() now finds the clock via device
> tree instead of a clkdev lookup entry. However, I think that the PM
> notifier registered in arch/arm/mach-davinci/pm_domain.c only uses
> the clkdev lookup to match the con_id and does not use device tree.
> The same thing is happing in mdio, emac and lcdc.
> 

Minor correction: It looks like emac doesn't do this because it doesn't
have a con_id of "fck". But, the same clock is shared by emac and mdio, so
since mdio enables the clock, emac doesn't notice or care that it did
not enable the clock itself.