linux-kernel - Re: [patch v10 4/6] platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180123225817.GB16464@fury>
Date:   Tue, 23 Jan 2018 14:58:17 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Vadim Pasternak <vadimp@...lanox.com>
Cc:     andy.shevchenko@...il.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        jiri@...nulli.us
Subject: Re: [patch v10 4/6] platform/mellanox: mlxreg-hotplug: Modify to use
 a regmap interface

On Tue, Jan 23, 2018 at 08:34:23PM +0000, Vadim Pasternak wrote:
> Restructure mlxreg header for unification of hotplug item definitions.
> 
> Unify hotplug items to allow any kind of item (power controller, fan
> eeprom, psu eeprom, asic health) in common way.
> 
> Use a hardware independent regmap interface, enabling the support of
> hotplug events over programmable devices attached to different bus
> types, such as I2C, LPC, or SPI. Add a device node to the
> mlxreg_core_data structure.
> 
> Signed-off-by: Vadim Pasternak <vadimp@...lanox.com>
> Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>
> ---
> v10->v9:
>  Fixes provided by Vadim:
>  - add missed description of pdev_hotplug for struct mlxplat_priv;

I didn't see this in the diff from my version to this one.

>  - remove struct mlxplat_mlxcpld_regmap_context, which contains only
>    the field with base address. Instead obtain locally defined base
>    address by devm_ioport_map in mlxplat_init and pass it to
>    devm_regmap_init;
>  - modify mlxplat_mlxcpld_reg_read/write to use directly pointer to
>    context;

Also adds incorrect conversion of tabs to spaces in at least 3 locations ...

I had also corrected various typos and the copyright statement, as well as
reworked the commit messages. So at this point, I'd rather see these as changes
on top of what I have cleaned up.

Please compare what you have here with:
https://github.com/dvhart/linux-pdx86/tree/review-dvhart-mellanox-v10

And send me any changes strictly on top of that.

Are you anticipating any additional changes beyond those in this version?

-- 
Darren Hart
VMware Open Source Technology Center