linux-kernel - Re: [PATCH] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2205915.z0ubSpqczI@avalon>
Date:   Wed, 24 Jan 2018 01:32:08 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Philippe CORNU <philippe.cornu@...com>
Cc:     Archit Taneja <architt@...eaurora.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        David Airlie <airlied@...ux.ie>,
        Brian Norris <briannorris@...omium.org>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Bhumika Goyal <bhumirks@...il.com>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Sandy Huang <hjc@...k-chips.com>,
        Heiko Stubner <heiko@...ech.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-rockchip@...ts.infradead.org" 
        <linux-rockchip@...ts.infradead.org>,
        Yannick FERTRE <yannick.fertre@...com>,
        Vincent ABRIOU <vincent.abriou@...com>,
        Alexandre TORGUE <alexandre.torgue@...com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Ludovic BARRE <ludovic.barre@...com>,
        Mickael REULIER <mickael.reulier@...com>
Subject: Re: [PATCH] drm/bridge/synopsys: dsi: Adopt SPDX identifiers

Hi Philippe,

On Tuesday, 23 January 2018 12:25:51 EET Philippe CORNU wrote:
> On 01/23/2018 12:30 AM, Laurent Pinchart wrote:
> > On Monday, 22 January 2018 12:26:08 EET Philippe Cornu wrote:
> >> Add SPDX identifiers to the Synopsys DesignWare MIPI DSI
> >> host controller driver.
> >>
> >> Signed-off-by: Philippe Cornu <philippe.cornu@...com>
> >> ---
> >> 
> >>   drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 6 +-----
> >>   1 file changed, 1 insertion(+), 5 deletions(-)
> >>
> >> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> >> b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c index
> >> 46b0e73404d1..e06836dec77c 100644
> >> --- a/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> >> +++ b/drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c
> >> @@ -1,12 +1,8 @@
> >> +// SPDX-License-Identifier: GPL-2.0
> > 
> > According to Documentation/process/license-rules.txt this would change
> > the existing license. The correct identifier is GPL-2.0+.
> 
> You are right, I did not put the correct identifier :(
> 
> After reading more spdx.org, I wonder if the correct value should be 
> GPL-2.0-or-later instead of GPL-2.0+
> 
> https://spdx.org/licenses/GPL-2.0-or-later.html
> https://spdx.org/licenses/GPL-2.0+.html
> 
> What is your opinion?

I agree in principle, and I've even asked for that before, but I've been told 
that we should stick to the license identifiers defined in Documentation/
process/license-rules.txt. The file might get updated to use GPL-2.0-or-later 
and GPL-2.0-only later, and kernel sources will likely then get patched in one 
go.

> >>  /*
> >>   * Copyright (c) 2016, Fuzhou Rockchip Electronics Co., Ltd
> >>   * Copyright (C) STMicroelectronics SA 2017
> >>   *
> >> - * This program is free software; you can redistribute it and/or modify
> >> - * it under the terms of the GNU General Public License as published by
> >> - * the Free Software Foundation; either version 2 of the License, or
> >> - * (at your option) any later version.
> >> - *
> >>   * Modified by Philippe Cornu <philippe.cornu@...com>
> >>   * This generic Synopsys DesignWare MIPI DSI host driver is based on the
> >>   * Rockchip version from rockchip/dw-mipi-dsi.c with phy & bridge APIs.

-- 
Regards,

Laurent Pinchart