linux-kernel - Re: [PATCH 14/14] MIPS: memblock: Deactivate bootmem allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180123235934.GA5446@saruman>
Date:   Tue, 23 Jan 2018 23:59:35 +0000
From:   James Hogan <jhogan@...nel.org>
To:     Serge Semin <fancer.lancer@...il.com>
Cc:     ralf@...ux-mips.org, miodrag.dinic@...s.com, goran.ferenc@...s.com,
        david.daney@...ium.com, paul.gortmaker@...driver.com,
        paul.burton@...s.com, alex.belits@...ium.com,
        Steven.Hill@...ium.com, alexander.sverdlin@...ia.com,
        matt.redfearn@...s.com, kumba@...too.org,
        marcin.nowakowski@...s.com, Peter.Wotton@...s.com,
        Sergey.Semin@...latforms.ru, linux-mips@...ux-mips.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 14/14] MIPS: memblock: Deactivate bootmem allocator

On Thu, Jan 18, 2018 at 01:23:12AM +0300, Serge Semin wrote:
> Memblock allocator can be successfully used from now for early
> memory management
> 
> Signed-off-by: Serge Semin <fancer.lancer@...il.com>

Am I correct that intermediate commits in this patchset (i.e. bisection)
may not work correctly, since bootmem will have been stripped out but
NO_BOOTMEM=n and memblock may not be properly operational yet?

If so, is there a way to switch without breaking bisection that doesn't
involve squashing most of the series into a single atomic commit?

Cheers
James

> ---
>  arch/mips/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
> index 725b5ece7..a6c4fb6b6 100644
> --- a/arch/mips/Kconfig
> +++ b/arch/mips/Kconfig
> @@ -4,7 +4,6 @@ config MIPS
>  	default y
>  	select ARCH_BINFMT_ELF_STATE
>  	select ARCH_CLOCKSOURCE_DATA
> -	select ARCH_DISCARD_MEMBLOCK
>  	select ARCH_HAS_ELF_RANDOMIZE
>  	select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST
>  	select ARCH_MIGHT_HAVE_PC_PARPORT
> @@ -57,6 +57,7 @@ config MIPS
>  	select HAVE_IRQ_TIME_ACCOUNTING
>  	select HAVE_KPROBES
>  	select HAVE_KRETPROBES
> +	select NO_BOOTMEM
>  	select HAVE_MEMBLOCK
>  	select HAVE_MEMBLOCK_NODE_MAP
>  	select HAVE_MOD_ARCH_SPECIFIC
> -- 
> 2.12.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)