linux-kernel - Re: [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC module and driver names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180124.162737.1427515957453841771.davem@davemloft.net>
Date:   Wed, 24 Jan 2018 16:27:37 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     Vadim.Lomovtsev@...iumnetworks.com
Cc:     sgoutham@...ium.com, rric@...nel.org,
        linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Vadim.Lomovtsev@...ium.com,
        dnelson@...hat.com
Subject: Re: [PATCH v3] net: ethernet: cavium: Correct Cavium Thunderx NIC
 module and driver names

From: Vadim Lomovtsev <Vadim.Lomovtsev@...iumnetworks.com>
Date: Mon, 22 Jan 2018 06:13:27 -0800

> From: Vadim Lomovtsev <Vadim.Lomovtsev@...ium.com>
> 
> It was found that ethtool provides unexisting module name while
> it queries the specified network device for associated driver
> information. Then user tries to unload that module by provided
> module name and fails.
> 
> This happens because ethtool reads value of DRV_NAME macro,
> while module name is defined at the driver's Makefile.
> 
> This patch is to correct Cavium CN88xx Thunder NIC driver modules
> names 'nicvf' to 'thunder_nicvf' and 'nicpf' to 'thunder_nicpf' along
> with updating DRV_NAME macro values accordingly.
> 
> Signed-off-by: Dean Nelson <dnelson@...hat.com>
> Signed-off-by: Vadim Lomovtsev <Vadim.Lomovtsev@...ium.com>

Once your driver has been deployed in a real upstream release you
should never change the driver module name.

So if you want to fix things, you'll have to fix them the other
way around, by not changing the module name but changing the
strings that ethtool ends up with instead.

Thank you.