linux-kernel - RE: [PATCH 3/3] tpm: add longer timeouts for creation commands.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B94203937@hasmsx108.ger.corp.intel.com>
Date:   Wed, 24 Jan 2018 21:29:19 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
CC:     "Usyskin, Alexander" <alexander.usyskin@...el.com>,
        "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
        "linux-security-module@...r.kernel.org" 
        <linux-security-module@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/3] tpm: add longer timeouts for creation commands.



> -----Original Message-----
> From: Jarkko Sakkinen [mailto:jarkko.sakkinen@...ux.intel.com]
> Sent: Tuesday, January 23, 2018 15:12
> To: Winkler, Tomas <tomas.winkler@...el.com>
> Cc: Jason Gunthorpe <jgunthorpe@...idianresearch.com>; Usyskin,
> Alexander <alexander.usyskin@...el.com>; tpmdd-
> devel@...ts.sourceforge.net; linux-integrity@...r.kernel.org; linux-security-
> module@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 3/3] tpm: add longer timeouts for creation commands.
> 
> On Tue, Jan 23, 2018 at 01:27:31PM +0200, Tomas Winkler wrote:
> > TPM2_CC_Create(0x153) and TPM2_CC_CreatePrimary (0x131) involve
> > generation of crypto keys which can be a computationally intensive task.
> > The timeout is set to 3min.
> >
> > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> 
> From where are these numbers are derived from?

An Intel SW architect.
 
> 
> Can you send 1/3 and 2/3 as a separate patch set with a cover letter (with
> explanation) and this as a separate patch? This is unrelated to first two
> changes albeit might make sense.

Will do, though the patches were born to  address the initialization issues we've encountered.
Thanks
Tomas