linux-kernel - Re: [GIT PULL] PCI fixes for v4.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180124004603.GH5317@bhelgaas-glaptop.roam.corp.google.com>
Date:   Tue, 23 Jan 2018 18:46:03 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
Cc:     linux-pci@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Christian König <christian.koenig@....com>,
        Aaro Koskinen <aaro.koskinen@....fi>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Juergen Gross <jgross@...e.com>,
        Alex Deucher <alexander.deucher@....com>,
        David Airlie <airlied@...ux.ie>
Subject: Re: [GIT PULL] PCI fixes for v4.15

On Tue, Jan 23, 2018 at 12:49:22PM -0800, Linus Torvalds wrote:
> On Tue, Jan 23, 2018 at 11:56 AM, Bjorn Helgaas <helgaas@...nel.org> wrote:
> >
> >   - fix AMD regression due to not re-enabling the big window on resume
> >     (Christian König)
> 
> Bjorn, I think you need to look at your email habits.
> 
> I suspect you're editing your mailbox, or you're using some broken
> mailer setup, or something (using some broken "export" function?),
> because you're corrupting Christian's name all the time:
> 
> > =?UTF-8?q?Christian=20K=C3=B6nig?= (1):
> >       x86/PCI: Enable AMD 64-bit window on resume
> 
> and I'm pretty sure git gets this right if actually fed a real mbox,
> but I suspect that you have some other workflow going on..

I'm not editing my mailbox, but I am using stgit.  The "From:" header
uses encoded-word syntax for Christian's name, and I think stgit is
not decoding that when applying the patch.

When I save the patch email message from mutt (or gmail, for that
matter), I see:

  From: "=?UTF-8?q?Christian=20K=C3=B6nig?="  ...

Applying that patch with "git am" results in the correct

  Author: Christian König <ckoenig.leichtzumerken@...il.com

Applying the identical patch with "stg import -M" results in

  Author: =?UTF-8?q?Christian=20K=C3=B6nig?= <ckoenig.leichtzumerken@...il.com>

Some of Christian's PCI patches came out OK (8bb705e3e79d,
276b738deb5b, cb21bc9469c4).  I don't remember specifically, but I
suspect I fixed those manually.

I don't know if there's some stg configuration I could do to fix this.
I looked a little bit but haven't found anything yet.

Thanks for pointing this out.  I'll try to fix this one way or another
in the future.

Bjorn