linux-kernel - Re: [PATCH 2/3] pwm: pwm-omap-dmtimer: Fix frequency when using prescaler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cc075969-872e-1ec1-a854-2e19f2c952fe@ti.com>
Date:   Wed, 24 Jan 2018 10:56:07 +0530
From:   Keerthy <j-keerthy@...com>
To:     Ladislav Michl <ladis@...ux-mips.org>,
        Claudiu Beznea <Claudiu.Beznea@...rochip.com>
CC:     <linux-omap@...r.kernel.org>, <linux-pwm@...r.kernel.org>,
        <daniel.lezcano@...aro.org>, <thierry.reding@...il.com>,
        <tony@...mide.com>, <aaro.koskinen@....fi>,
        <narmstrong@...libre.com>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <sebastian.reichel@...labora.co.uk>, <robh+dt@...nel.org>,
        <t-kristo@...com>, <grygorii.strashko@...com>
Subject: Re: [PATCH 2/3] pwm: pwm-omap-dmtimer: Fix frequency when using
 prescaler



On Monday 22 January 2018 04:23 PM, Ladislav Michl wrote:
> Dear Claudiu,
> 
> On Mon, Jan 22, 2018 at 11:17:08AM +0200, Claudiu Beznea wrote:
>> On 17.01.2018 23:47, Ladislav Michl wrote:
>>> @@ -334,18 +348,18 @@ static int pwm_omap_dmtimer_probe(struct platform_device *pdev)
>>>  
>>>  	mutex_init(&omap->mutex);
>>>  
>>> -	status = pwmchip_add(&omap->chip);
>>> -	if (status < 0) {
>>> +	ret = pwmchip_add(&omap->chip);
>>> +	if (ret < 0) {
>>>  		dev_err(&pdev->dev, "failed to register PWM\n");
>>> -		omap->pdata->free(omap->dm_timer);
>>> -		ret = status;
>>> -		goto put;
>>> +		goto free;
>>>  	}
>>>  
>>>  	platform_set_drvdata(pdev, omap);
>> >From documentation: "of_parse_phandle(): Returns the device_node pointer with refcount
>> incremented. Use of_node_put() on it when done."
>> In case of success the of_node_put() should also be called as I see.
> 
> Based on you previous suggestions found here:
> https://patchwork.kernel.org/patch/10140209/
> I'd say this fix belongs to patch which introduces of_node_put() in the error
> path. I'll then rebase this patches on top of the fix.

Agreed. I missed the success path as i assumed only error paths needed
te of_node_put(). I will post v8 of this patch alone as other patches
can be left untouched. Hope that is okay.

Regards,
Keerthy
> 
> Thank you,
> 	ladis
>