linux-kernel - Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180124062725.GK27654@lahna.fi.intel.com>
Date:   Wed, 24 Jan 2018 08:27:25 +0200
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     Eric Auger <eric.auger@...hat.com>, eric.auger.pro@...il.com,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org,
        okaya@...eaurora.org
Subject: Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a
 module

On Wed, Jan 24, 2018 at 06:56:16AM +0100, Wolfram Sang wrote:
> On Wed, Jan 03, 2018 at 03:02:31PM +0100, Eric Auger wrote:
> > If I2C is built as a module, ACPI_I2C_OPREGION cannot be set
> > and any ACPI opregion calls targeting I2C fail with no opregion found.
> > 
> > This patch allows ACPI_I2C_OPREGION to be enabled both if I2C is
> > built into the kernel or built as a module.
> > 
> > Signed-off-by: Eric Auger <eric.auger@...hat.com>
> 
> I recall that we had some discussion until ending up with the current
> solution. And I finally found it again:
> 
> http://www.serverphorums.com/read.php?12,1001402
> 
> In any case, I surely want Mika's ack on any change to ACPI related
> Kconfig symbols. Adding him to CC...

So the problem is/was that what happens if you are in a middle of BIOS
AML code touching the opregion and someone unloads the opregion handler?
If you can quarantee nothing bad happens, then I'm fine with the patch :)