linux-kernel - Re: [PATCH v2] perf/core: Fix installing cgroup event into cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180124094636.GP2228@hirez.programming.kicks-ass.net>
Date:   Wed, 24 Jan 2018 10:46:36 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Lin Xiulei <linxiulei@...il.com>
Cc:     Jiri Olsa <jolsa@...hat.com>, mingo@...hat.com, acme@...nel.org,
        alexander.shishkin@...ux.intel.com, linux-kernel@...r.kernel.org,
        tglx@...utronix.de, Stephane Eranian <eranian@...il.com>,
        torvalds@...ux-foundation.org, linux-perf-users@...r.kernel.org,
        Brendan Gregg <brendan.d.gregg@...il.com>,
        yang_oliver@...mail.com, jinli.zjl@...baba-inc.com,
        "leilei.lin" <leilei.lin@...baba-inc.com>
Subject: Re: [PATCH v2] perf/core: Fix installing cgroup event into cpu

On Wed, Jan 24, 2018 at 05:19:34PM +0800, Lin Xiulei wrote:
> Sure, and I consider this "OK" works for "What goes wrong if we leave
> it set?". : )

It would be good if you inspect the code for the case of leaving
cpuctx->cgrp set with no cgroup events left -- AND -- put a blurb about
what you found in your new Changelog.

I suspect it works out and something like perf_cgroup_switch() will fix
things up for us later, but double check and test.