linux-kernel - Re: [PATCH v2] bsg: use pr_debug instead of hand craftet macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1516792426.8378.40.camel@perches.com>
Date:   Wed, 24 Jan 2018 03:13:46 -0800
From:   Joe Perches <joe@...ches.com>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     Bart Van Assche <Bart.VanAssche@....com>,
        "axboe@...com" <axboe@...com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>
Subject: Re: [PATCH v2] bsg: use pr_debug instead of hand craftet macros

On Wed, 2018-01-24 at 09:03 +0100, Johannes Thumshirn wrote:
> On Tue, Jan 23, 2018 at 06:53:18PM -0800, Joe Perches wrote:
> > On Tue, 2018-01-23 at 23:12 +0000, Bart Van Assche wrote:
> > > On Tue, 2018-01-23 at 04:45 -0800, Joe Perches wrote:
> > > > Perhaps the email subject could be improved to describe
> > > > the new macro and as well, this macro, without a pr_fmt
> > > > define somewhat above it loses the __func__ output too.
> > > 
> > > Hmm ... I thought that the pr_debug() output can be configured to include
> > > the function name (__func__)? From
> > 
> > Exactly right.
> > 
> > > https://www.kernel.org/doc/html/latest/admin-guide/dynamic-debug-howto.html:
> > 
> > which is what I wrote when I said use +f.
> > 
> > It's just nice to mention these changes in the
> > commit message.
> 
> Sorry Joe but this slowly approaches the bikeshedding area. Why should I
> duplicate the dynamic debug howto?

Up to you if you want your commit messages to be
more descriptive of the changes you are making.