linux-kernel - Re: [PATCH] drm/etnaviv: fix '%x' warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1516795026.6411.7.camel@pengutronix.de>
Date:   Wed, 24 Jan 2018 12:57:06 +0100
From:   Lucas Stach <l.stach@...gutronix.de>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        Russell King <linux+etnaviv@...linux.org.uk>,
        Christian Gmeiner <christian.gmeiner@...il.com>,
        David Airlie <airlied@...ux.ie>
Cc:     etnaviv@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org,
        "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Subject: Re: [PATCH] drm/etnaviv: fix '%x' warning

Hi Gustavo,

Am Dienstag, den 23.01.2018, 11:07 -0600 schrieb Gustavo A. R. Silva:
> Fix the following warning by using %zx instead of %x for variable of
> type size_t:
> 
> warning: format ‘%x’ expects argument of type ‘unsigned int’, but
> argument 4 has type ‘size_t {aka long unsigned int}’ [-Wformat=]
> 
> Fixes: 50073cf98d16 ("drm/etnaviv: mmu: stop using iommu map/unmap functions")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

Thanks for the patch, but I already have an equivalent change queued up.

Regards,
Lucas

> ---
> This code was compiled with GCC 7.2.0
> 
>  drivers/gpu/drm/etnaviv/etnaviv_mmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> index d113fe0..49e0497 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_mmu.c
> @@ -29,7 +29,7 @@ static void etnaviv_domain_unmap(struct etnaviv_iommu_domain *domain,
> >  	size_t pgsize = SZ_4K;
>  
> >  	if (!IS_ALIGNED(iova | size, pgsize)) {
> > -		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%x\n",
> > +		pr_err("unaligned: iova 0x%lx size 0x%zx min_pagesz 0x%zx\n",
> >  		       iova, size, pgsize);
> >  		return;
> >  	}
> @@ -54,7 +54,7 @@ static int etnaviv_domain_map(struct etnaviv_iommu_domain *domain,
> >  	int ret = 0;
>  
> >  	if (!IS_ALIGNED(iova | paddr | size, pgsize)) {
> > -		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%x\n",
> > +		pr_err("unaligned: iova 0x%lx pa %pa size 0x%zx min_pagesz 0x%zx\n",
> >  		       iova, &paddr, size, pgsize);
> >  		return -EINVAL;
> >  	}