linux-kernel - Re: [PATCH] crypto: picoxcell - Fix error handling in spacc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180124130825.tjcywfbcdfikklfl@willow>
Date:   Wed, 24 Jan 2018 13:08:25 +0000
From:   Jamie Iles <jamie@...ieiles.com>
To:     Alexey Khoroshilov <khoroshilov@...ras.ru>
Cc:     Jamie Iles <jamie@...ieiles.com>,
        Javier Martinez Canillas <javier@....samsung.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        linux-arm-kernel@...ts.infradead.org, linux-crypto@...r.kernel.org,
        linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org
Subject: Re: [PATCH] crypto: picoxcell - Fix error handling in spacc_probe()

Thanks Alexey!

On Sat, Jan 20, 2018 at 12:53:15AM +0300, Alexey Khoroshilov wrote:
> If clk_get() fails, device_remove_file() looks inappropriate.
> 
> The error path, where all crypto_register fail, misses resource
> deallocations.
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>

Reviewed-by: Jamie Iles <jamie@...ieiles.com>