linux-kernel - Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17f80dc5-126e-bf1e-8bcc-95a1e66cd271@codeaurora.org>
Date:   Wed, 24 Jan 2018 10:37:20 -0500
From:   Sinan Kaya <okaya@...eaurora.org>
To:     Hans de Goede <hdegoede@...hat.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Wolfram Sang <wsa@...-dreams.de>,
        Eric Auger <eric.auger@...hat.com>, eric.auger.pro@...il.com,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>
Subject: Re: [PATCH v2] i2c: Allow ACPI_I2C_OPREGION if I2C is built as a
 module

On 1/24/2018 10:23 AM, Hans de Goede wrote:
>> There must be a middle ground somewhere.
> 
> One thing which comes to mind is to simply not allow building i2c as a module
> when ACPI is selected, something like this should work I think:
> 
>  config I2C
>          tristate "I2C support"
>          select RT_MUTEXES
>          select IRQ_DOMAIN
> +        # force building I2C in on ACPI systems, for opregion availability
> +        depends on y || !ACPI

This works for me.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.