linux-kernel - Re: [PATCH] Revert "module: Add retpoline tag to VERMAGIC"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180124154401.GA26209@tassilo.jf.intel.com>
Date:   Wed, 24 Jan 2018 07:44:01 -0800
From:   Andi Kleen <ak@...ux.intel.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Jiri Kosina <jikos@...nel.org>, torvalds@...ux-foundation.org,
        Thomas Gleixner <tglx@...utronix.de>,
        David Woodhouse <dwmw@...zon.co.uk>, rusty@...tcorp.com.au,
        arjan.van.de.ven@...el.com, jeyu@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "module: Add retpoline tag to VERMAGIC"

On Wed, Jan 24, 2018 at 03:28:17PM +0100, Greg Kroah-Hartman wrote:
> This reverts commit 6cfb521ac0d5b97470883ff9b7facae264b7ab12.
> 
> Turns out distros do not want to make retpoline as part of their "ABI",
> so this patch should not have been merged.  Sorry Andi, this was my
> fault, I suggested it when your original patch was the "correct" way of
> doing this instead.

It's ok for me to revert, but if it's reverted should consider
the warning only patch version instead.

https://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git/commit/?h=spec/retpoline-module-2&id=b40b7c1dbffaa636906b774ef5519882060e1aa0

I had posted that earlier, but reviewers in the end preferred
the simple modversions variant.

I think we should have something at least for 4.15 to catch mistakes.

-Andi