linux-kernel - Re: [tip:x86/hyperv] x86/hyperv: Stop suppressing X86_FEATURE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 24 Jan 2018 08:27:40 -0800
From:   Andy Lutomirski <luto@...nel.org>
To:     dazhan@...rosoft.com, Haiyang Zhang <haiyangz@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        LKML <linux-kernel@...r.kernel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andrew Lutomirski <luto@...nel.org>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Michael.H.Kelley@...rosoft.com, adityabh@...rosoft.com,
        Ingo Molnar <mingo@...nel.org>,
        Stephen Hemminger <sthemmin@...rosoft.com>
Cc:     linux-tip-commits@...r.kernel.org
Subject: Re: [tip:x86/hyperv] x86/hyperv: Stop suppressing X86_FEATURE_PCID

On Wed, Jan 24, 2018 at 4:48 AM, tip-bot for Vitaly Kuznetsov
<tipbot@...or.com> wrote:
> Commit-ID:  04651dd978a8749e59065df14b970a127f219ac2
> Gitweb:     https://git.kernel.org/tip/04651dd978a8749e59065df14b970a127f219ac2
> Author:     Vitaly Kuznetsov <vkuznets@...hat.com>
> AuthorDate: Wed, 24 Jan 2018 11:36:29 +0100
> Committer:  Thomas Gleixner <tglx@...utronix.de>
> CommitDate: Wed, 24 Jan 2018 13:44:57 +0100
>
> x86/hyperv: Stop suppressing X86_FEATURE_PCID
>
> When hypercall-based TLB flush was enabled for Hyper-V guests PCID feature
> was deliberately suppressed as a precaution: back then PCID was never
> exposed to Hyper-V guests and it wasn't clear what will happen if some day
> it becomes available. The day came and PCID/INVPCID features are already
> exposed on certain Hyper-V hosts.
>
> From TLFS (as of 5.0b) it is unclear how TLB flush hypercalls combine with
> PCID. In particular the usage of PCID is per-cpu based: the same mm gets
> different CR3 values on different CPUs. If the hypercall does exact
> matching this will fail. However, this is not the case. David Zhang
> explains:
>
>  "In practice, the AddressSpace argument is ignored on any VM that supports
>   PCIDs.
>
>   Architecturally, the AddressSpace argument must match the CR3 with PCID
>   bits stripped out (i.e., the low 12 bits of AddressSpace should be 0 in
>   long mode). The flush hypercalls flush all PCIDs for the specified
>   AddressSpace."
>
> With this, PCID can be enabled.

So what, exactly, does the flush hypercall do?

--Andy