linux-kernel - Re: [tip:perf/urgent] perf/core: Fix lock inversion between perf,trace,cpuhp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyq=NbiYrbYst34iRU9M7-hA5UNMKJ9aAcS+ADs7bBhQA@mail.gmail.com>
Date:   Wed, 24 Jan 2018 08:57:10 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Peter Zijlstra <peterz@...radead.org>, Peter Anvin <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perf/urgent] perf/core: Fix lock inversion between perf,trace,cpuhp

On Wed, Jan 24, 2018 at 7:32 AM, Ingo Molnar <mingo@...nel.org> wrote:
>
> Oh, the '#' was probably interpreted as a comment when I applied it ...

Indeed. That's a subtle gotcha when you cut-and-paste things into the
editor when editing a commit message (including the "git rebase -i" or
"git commit --amend" kind of editing).

If you just apply it as an email, the hash-marks at the beginning of
lines are not seen as comments - it's literally just the editing part
that uses them as comments.

I'm afraid this isn't really a git "bug". But it _is_ subtle and unlucky.

Note that only a hash-mark in the first column is seen as a comment
(unlike, say, shell programming), so you can avoid it with spacing. If
you quote code with #ifdef etc, indent it.

Maybe git should have used a different comment scheme, but I have to
admit that I think this is the first time I've heard of this issue
causing problems in practice. I'm sure it's triggered before, and
nobody has noticed (or I wasn't on the cc).

So the '#' thing _normally_ works, but yes, it can cause issues.

                   Linus