linux-kernel - Re: [PATCH 1/2] regmap: fix NULL pointer dereference in regmap_name_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180124170448.GJ9366@sirena.org.uk>
Date:   Wed, 24 Jan 2018 17:04:48 +0000
From:   Mark Brown <broonie@...nel.org>
To:     David Lechner <david@...hnology.com>
Cc:     Lars-Peter Clausen <lars@...afoo.de>, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/2] regmap: fix NULL pointer dereference in
 regmap_name_read_file()

On Wed, Jan 24, 2018 at 10:27:22AM -0600, David Lechner wrote:
> On 01/24/2018 10:19 AM, Mark Brown wrote:

> > Indeed.  It is an improvement but not exactly helpful.

> Would it be better if it said "this regmap does not have driver" instead
> of "(null)"?

That's both not idiomatically good and isn't even true...  ideally we'd
be able to get some sort of string out of the user, but otherwise
"nodev" or perhaps printing the pointer to the regmap (to avoid
collisions if there's more than one of these in a system).

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)