linux-kernel - [PATCH 1/2] Input: appletouch: Delete an error message for a failed memory allocation in atp_geyser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fd7ba984-5294-78f7-73e3-7f6a37ed9dee@users.sourceforge.net>
Date:   Wed, 24 Jan 2018 20:56:11 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     linux-input@...r.kernel.org,
        Arvind Yadav <arvind.yadav.cs@...il.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH 1/2] Input: appletouch: Delete an error message for a failed
 memory allocation in atp_geyser_init()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Wed, 24 Jan 2018 20:40:54 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/input/mouse/appletouch.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/mouse/appletouch.c b/drivers/input/mouse/appletouch.c
index 81a695d0b4e0..3a709d21ea93 100644
--- a/drivers/input/mouse/appletouch.c
+++ b/drivers/input/mouse/appletouch.c
@@ -280,10 +280,8 @@ static int atp_geyser_init(struct atp *dev)
 	int ret;
 
 	data = kmalloc(8, GFP_KERNEL);
-	if (!data) {
-		dev_err(&dev->intf->dev, "Out of memory\n");
+	if (!data)
 		return -ENOMEM;
-	}
 
 	size = usb_control_msg(udev, usb_rcvctrlpipe(udev, 0),
 			ATP_GEYSER_MODE_READ_REQUEST_ID,
-- 
2.16.1