linux-kernel - Re: [PATCH-next] powerpc/fsl_pci: Use PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <dff06bae-9624-b688-2865-99aca16b9214@linux.vnet.ibm.com>
Date:   Tue, 23 Jan 2018 19:33:10 -0800
From:   Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>
To:     Christopher Díaz Riveros <chrisadr@...too.org>,
        benh@...nel.crashing.org, paulus@...ba.org, mpe@...erman.id.au,
        joe@...ches.com, christian.koenig@....com,
        tyreld@...ux.vnet.ibm.com, konrad.wilk@...cle.com, robh@...nel.org
Cc:     linuxppc-dev@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH-next] powerpc/fsl_pci: Use PTR_ERR_OR_ZERO

On 01/23/2018 12:37 PM, Christopher Díaz Riveros wrote:
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> This issue was detected by using the Coccinelle software.
> 
> Signed-off-by: Christopher Díaz Riveros <chrisadr@...too.org>
> ---

Reviewed-by: Tyrel Datwyler <tyreld@...ux.vnet.ibm.com>

>  arch/powerpc/sysdev/fsl_pci.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/arch/powerpc/sysdev/fsl_pci.c b/arch/powerpc/sysdev/fsl_pci.c
> index cc20d2255d7f..142184635c81 100644
> --- a/arch/powerpc/sysdev/fsl_pci.c
> +++ b/arch/powerpc/sysdev/fsl_pci.c
> @@ -1304,10 +1304,7 @@ static int add_err_dev(struct platform_device *pdev)
>  						   pdev->resource,
>  						   pdev->num_resources,
>  						   &pd, sizeof(pd));
> -	if (IS_ERR(errdev))
> -		return PTR_ERR(errdev);
> -
> -	return 0;
> +	return PTR_ERR_OR_ZERO(errdev);
>  }
>  
>  static int fsl_pci_probe(struct platform_device *pdev)
>