linux-kernel - [PATCH 2/3] Input: bcm5974: Return directly after a failed kmalloc() in bcm5974_wellspring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8befb181-9f0e-84f4-9080-4bde3d666a3b@users.sourceforge.net>
Date:   Wed, 24 Jan 2018 21:31:09 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     linux-input@...r.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Henrik Rydberg <rydberg@...math.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: [PATCH 2/3] Input: bcm5974: Return directly after a failed kmalloc()
 in bcm5974_wellspring_mode()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Wed, 24 Jan 2018 21:14:51 +0100

Return directly after a call of the function "kmalloc" failed
at the beginning.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/input/mouse/bcm5974.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/input/mouse/bcm5974.c b/drivers/input/mouse/bcm5974.c
index 994805513df9..685f56c08931 100644
--- a/drivers/input/mouse/bcm5974.c
+++ b/drivers/input/mouse/bcm5974.c
@@ -669,10 +669,8 @@ static int bcm5974_wellspring_mode(struct bcm5974 *dev, bool on)
 		return 0;
 
 	data = kmalloc(c->um_size, GFP_KERNEL);
-	if (!data) {
-		retval = -ENOMEM;
-		goto out;
-	}
+	if (!data)
+		return -ENOMEM;
 
 	/* read configuration */
 	size = usb_control_msg(dev->udev, usb_rcvctrlpipe(dev->udev, 0),
-- 
2.16.1