linux-kernel - Re: [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Jan 2018 18:33:16 +0800
From:   Dong Aisheng <dongas86@...il.com>
To:     Anson Huang <Anson.Huang@....com>
Cc:     shawnguo@...nel.org, kernel@...gutronix.de, fabio.estevam@....com,
        robh+dt@...nel.org, aisheng.dong@....com, mark.rutland@....com,
        linux@...linux.org.uk, Linux-imx@....com,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: imx6sx: add ARM power domain support

On Wed, Jan 24, 2018 at 12:42:14AM +0800, Anson Huang wrote:
> Add ARM power domain in PGC.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
> this patch should be based on 0001-ARM-dts-imx6sx-add-pu-power-domain-support.patch
>  arch/arm/boot/dts/imx6sx.dtsi | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
> index 42ef4c6..aa29ca6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -768,6 +768,11 @@
>  					#address-cells = <1>;
>  					#size-cells = <0>;
>  
> +					power-domain@0 {

Nitpick: probably an 'arm' prefix is better:
arm: power-domain@0

Anyway, it's minor depends on maintainer's perference.

Otherwise, looks fine

Acked-by: Dong Aisheng <aisheng.dong@....com>

Regards
Dong Aisheng

> +						reg = <0>;
> +						#power-domain-cells = <0>;
> +					};
> +
>  					pd_pu: power-domain@1 {
>  						reg = <1>;
>  						#power-domain-cells = <0>;
> -- 
> 2.7.4
>