linux-kernel - Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3-Cx0Az9d6rpVUA4dRtCH7kghS65MOEGp0zd5tyU2FFQ@mail.gmail.com>
Date:   Thu, 25 Jan 2018 11:51:34 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Steve Longerbeam <slongerbeam@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Subject: Re: [PATCH] staging: imx-media-vdic: fix inconsistent IS_ERR and PTR_ERR

On Wed, Jan 24, 2018 at 1:43 AM, Gustavo A. R. Silva
<gustavo@...eddedor.com> wrote:
> Fix inconsistent IS_ERR and PTR_ERR in vdic_get_ipu_resources.
> The proper pointer to be passed as argument is ch.
>
> This issue was detected with the help of Coccinelle.
>
> Fixes: 0b2e9e7947e7 ("media: staging/imx: remove confusing IS_ERR_OR_NULL usage")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>

good catch!

Acked-by: Arnd Bergmann <arnd@...db.de>