linux-kernel - Re: [PATCH arm/aspeed/ast2500 v1] eSPI: add Aspeed AST2500 eSPI driver to boot a host with PCH runs on eSPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1516882990.7000.1250.camel@linux.intel.com>
Date:   Thu, 25 Jan 2018 14:23:10 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     "Wang, Haiyue" <haiyue.wang@...ux.intel.com>,
        Greg KH <gregkh@...uxfoundation.org>
Cc:     joel@....id.au, arnd@...db.de, openbmc@...ts.ozlabs.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH arm/aspeed/ast2500 v1] eSPI: add Aspeed AST2500 eSPI
 driver to boot a host with PCH runs on eSPI

On Thu, 2018-01-25 at 10:29 +0800, Wang, Haiyue wrote:
> 
> On 2018-01-23 16:44, Greg KH wrote:
> > On Tue, Jan 16, 2018 at 07:52:32PM +0800, Haiyue Wang wrote:

> > > +	depends on ARCH_ASPEED || COMPILE_TEST
> > > +	select REGMAP_MMIO
> > 
> > Select or depend?
> 
> Before, I used "depends on". I was told to to change "select". I'm
> not 
> sure which is more better by practice ?

git grep will answer to this question, but also documentation is good to
read.

REGMAP API is selected by users.

One case where it's not so looks like a bug.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy