linux-kernel - Re: [PATCH] ata: pata_pdc2027x: Replace mdelay with msleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180125153055.GE17457@devbig577.frc2.facebook.com>
Date:   Thu, 25 Jan 2018 07:30:55 -0800
From:   Tejun Heo <tj@...nel.org>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     b.zolnierkie@...sung.com, linux-ide@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: pata_pdc2027x: Replace mdelay with msleep

On Thu, Jan 25, 2018 at 06:45:05PM +0800, Jia-Ju Bai wrote:
> After checking all possible call chains to pdc_adjust_pll and
> pdc_detect_pll_input_clock,
> my tool finds that these functions are never called in atomic context,
> namely never in an interrupt handler or holding a spinlock.
> And their caller functions pdc2027x_init_one and pdc2027x_reinit_one 
> calls pci_enable_device which can sleep, and no spinlock is held when
> calling pdc_adjust_pll and pdc_detect_pll_input_clock,
> so it proves that pdc_adjust_pll and pdc_detect_pll_input_clock 
> can call functions which can sleep.
> Thus mdelay can be replaced with msleep to avoid busy wait.
> 
> Signed-off-by: Jia-Ju Bai <baijiaju1990@...il.com>

Applied to libata/for-4.16.

Thanks.

-- 
tejun