linux-kernel - [PATCH v3] ACPI: Force I2C to be selected as a built-in module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1516895011-17588-1-git-send-email-okaya@codeaurora.org>
Date:   Thu, 25 Jan 2018 10:43:31 -0500
From:   Sinan Kaya <okaya@...eaurora.org>
To:     linux-acpi@...r.kernel.org, timur@...eaurora.org
Cc:     eric.auger@...hat.com, hdegoede@...hat.com,
        mika.westerberg@...ux.intel.com, wsa@...-dreams.de,
        linux-i2c@...r.kernel.org, rjw@...ysocki.net,
        Sinan Kaya <okaya@...eaurora.org>, Len Brown <lenb@...nel.org>,
        linux-kernel@...r.kernel.org (open list)
Subject: [PATCH v3] ACPI: Force I2C to be selected as a built-in module

From: Auger Eric <eric.auger@...hat.com>

If I2C is built as a module, ACPI_I2C_OPREGION cannot be set
and any ACPI opregion calls targeting I2C fail with no opregion found.

Commit da3c6647ee08 ("I2C/ACPI: Clean up I2C ACPI code and Add
CONFIG_I2C_ACPI config") says following:

"Current there is a race between removing I2C ACPI operation region
and ACPI AML code accessing."

This patch forces core I2C support to be compiled as a built-in
module if ACPI is selected as code is not ready for dynamic module
removal.

Signed-off-by: Eric Auger <eric.auger@...hat.com>
Signed-off-by: Sinan Kaya <okaya@...eaurora.org>
---
 drivers/acpi/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 4650539..5b48098 100644
--- a/drivers/acpi/Kconfig
+++ b/drivers/acpi/Kconfig
@@ -9,6 +9,8 @@ menuconfig ACPI
 	depends on IA64 || X86 || ARM64
 	depends on PCI
 	select PNP
+	# force building I2C in on ACPI systems, for opregion availability
+	imply I2C
 	default y if (IA64 || X86)
 	help
 	  Advanced Configuration and Power Interface (ACPI) support for 
-- 
1.9.1