linux-kernel - Re: [RFC PATCH V4 1/5] workqueue: rename system workqueues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180125160110.GI17457@devbig577.frc2.facebook.com>
Date:   Thu, 25 Jan 2018 08:01:10 -0800
From:   Tejun Heo <tj@...nel.org>
To:     Wen Yang <wen.yang99@....com.cn>
Cc:     zhong.weidong@....com.cn, Jiang Biao <jiang.biao2@....com.cn>,
        Tan Hu <tan.hu@....com.cn>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH V4 1/5] workqueue: rename system workqueues

Hello,

On Thu, Jan 25, 2018 at 07:54:41AM -0800, Tejun Heo wrote:
> On Thu, Jan 25, 2018 at 03:01:40PM +0800, Wen Yang wrote:
> > Rename system_wq's wq->name from "events" to "system_percpu",
> > and similarly for the similarly named workqueues.
> > 
> > Signed-off-by: Wen Yang <wen.yang99@....com.cn>
> > Signed-off-by: Jiang Biao <jiang.biao2@....com.cn>
> > Signed-off-by: Tan Hu <tan.hu@....com.cn>
> > Suggested-by: Tejun Heo <tj@...nel.org>
> > Cc: Tejun Heo <tj@...nel.org>
> > Cc: Lai Jiangshan <jiangshanlai@...il.com>
> > Cc: linux-kernel@...r.kernel.org
> 
> The patches don't seem split right.  There are a number of chunks
> which seem to be in the wrong patch.  Can you plesae go over each
> patch and verify that they look, build and run okay?

Just building the same tree structure for different hierarchies.  Just
run tree(1) in /sys/fs/cgroup on a systemd cgroup1 system with some
controllers enabled and look at the output.

Thanks.

-- 
tejun