linux-kernel - Re: [RFC PATCH v11 4/5] PCI / PM: Add support for the PCIe WAKE# signal for OF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0h7JvEFTV1mbqxtK8P0aoums2Cvjy3uU1gK4E26_rtZ5g@mail.gmail.com>
Date:   Thu, 25 Jan 2018 17:54:23 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Brian Norris <briannorris@...omium.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        JeffyChen <jeffy.chen@...k-chips.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Linux PM <linux-pm@...r.kernel.org>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Doug Anderson <dianders@...omium.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Linux PCI <linux-pci@...r.kernel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>
Subject: Re: [RFC PATCH v11 4/5] PCI / PM: Add support for the PCIe WAKE#
 signal for OF

On Thu, Jan 25, 2018 at 5:40 PM, Tony Lindgren <tony@...mide.com> wrote:
> * Brian Norris <briannorris@...omium.org> [180125 01:22]:
>> On Fri, Jan 05, 2018 at 02:13:33AM +0100, Rafael J. Wysocki wrote:
>> > The "wakeup-interrupt" property at the bridge level basically has to be defined
>> > as the wakeup interrupt for all devices on the bus under the bridge.
>>
>> The only thing I'm at a loss for is whether this goes in (referring to
>> rk3399-gru.dtsi) &pcie or &pci_rootport. I think some versions of this
>> series have been aiming for the former, and some the latter.
>
> I'd keep the wakeup interrupt property at the rootport level. That way
> it can work with whatever pcie card that might be plugged into that
> slot. That is in case it's just a slot and not hardwired pcie device :)

Do I understand correctly that &pcie is the device and the
&pci_rootport is the port that device is connected to?