linux-kernel - Re: [RESEND PATCH 1/6] crypto: caam: Fix null dereference at error path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR0402MB33427BA4CB6A5D768E35CA9498E10@VI1PR0402MB3342.eurprd04.prod.outlook.com>
Date:   Thu, 25 Jan 2018 17:09:42 +0000
From:   Horia Geantă <horia.geanta@....com>
To:     Bryan O'Donoghue <pure.logic@...us-software.ie>,
        Aymen Sghaier <aymen.sghaier@....com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     Fabio Estevam <fabio.estevam@....com>, Peng Fan <peng.fan@....com>,
        "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "lukas.auer@...ec.fraunhofer.de" <lukas.auer@...ec.fraunhofer.de>,
        "rui.silva@...aro.org" <rui.silva@...aro.org>,
        "ryan.harkin@...aro.org" <ryan.harkin@...aro.org>
Subject: Re: [RESEND PATCH 1/6] crypto: caam: Fix null dereference at error
 path

On 1/24/2018 4:50 PM, Bryan O'Donoghue wrote:
> From: Rui Miguel Silva <rui.silva@...aro.org>
> 
> caam_remove already removes the debugfs entry, so we need to remove the one
> immediately before calling caam_remove.
> 
> This fix a NULL dereference at error paths is caam_probe fail.
> 
> [bod: changed name prefix to "crypto: caam: Fix .."]
> [bod: added Fixes tag]
> 
> Fixes: 67c2315def06 ("crypto: caam - add Queue Interface (QI) backend
> support")
Cc: <stable@...r.kernel.org> # 4.12+

> 
> Tested-by: Ryan Harkin <ryan.harkin@...aro.org>
> Signed-off-by: Rui Miguel Silva <rui.silva@...aro.org>
> Cc: "Horia Geantă" <horia.geanta@....com>
> Cc: Aymen Sghaier <aymen.sghaier@....com>
> Cc: Fabio Estevam <fabio.estevam@....com>
> Cc: Peng Fan <peng.fan@....com>
> Cc: Herbert Xu <herbert@...dor.apana.org.au>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Lukas Auer <lukas.auer@...ec.fraunhofer.de>
> Signed-off-by: Bryan O'Donoghue <pure.logic@...us-software.ie>
Reviewed-by: Horia Geantă <horia.geanta@....com>

Thanks,
Horia