linux-kernel - Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in mainline kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1801251945170.2203@nanos>
Date:   Thu, 25 Jan 2018 19:46:57 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Lyude Paul <lyude@...hat.com>
cc:     "Ghannam, Yazen" <Yazen.Ghannam@....com>,
        "hpa@...or.com" <hpa@...or.com>,
        "keith.busch@...el.com" <keith.busch@...el.com>,
        "mingo@...nel.org" <mingo@...nel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Borislav Petkov <bp@...en8.de>
Subject: Re: "irq/matrix: Spread interrupts on allocation" breaks nouveau in
 mainline kernel

On Thu, 25 Jan 2018, Lyude Paul wrote:

> I think you are right, apologies. Glad to know this isn't a regression in the
> IRQ handling code :). It looks like our nouveau problems are probably coming
> from the fact that we don't just leave IRQs setup through suspend/resume which
> as far as I can tell, is probably not the correct thing to do.

If you tear down the interrupt, then you have to make sure that it's
completely masked and disabled on the device side (including MSI).

Thanks,

	tglx