linux-kernel - Re: [PATCH v5 5/7] x86/pti: Do not enable PTI on processors which are not vulnerable to Meltdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f23ff04-f12e-d15b-31e8-6b48f2c13f19@intel.com>
Date:   Thu, 25 Jan 2018 11:53:29 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     David Woodhouse <dwmw@...zon.co.uk>, arjan@...ux.intel.com,
        tglx@...utronix.de, karahmed@...zon.de, x86@...nel.org,
        linux-kernel@...r.kernel.org, tim.c.chen@...ux.intel.com,
        bp@...en8.de, peterz@...radead.org, pbonzini@...hat.com,
        ak@...ux.intel.com, torvalds@...ux-foundation.org,
        gregkh@...ux-foundation.org, gnomes@...rguk.ukuu.org.uk,
        ashok.raj@...el.com, mingo@...nel.org,
        "Gross, Mark" <mark.gross@...el.com>,
        "Yang, Fei" <fei.yang@...el.com>
Subject: Re: [PATCH v5 5/7] x86/pti: Do not enable PTI on processors which are
 not vulnerable to Meltdown

On 01/25/2018 10:10 AM, Dave Hansen wrote:
> On 01/25/2018 08:14 AM, David Woodhouse wrote:
>> +static bool __init early_cpu_vulnerable_meltdown(struct cpuinfo_x86 *c)
>> +{
>> +	u64 ia32_cap = 0;
>> +
>> +	if (x86_match_cpu(cpu_no_meltdown))
>> +                return false;
>> +
>> +	if (cpu_has(c, X86_FEATURE_ARCH_CAPABILITIES))
>> +		rdmsrl(MSR_IA32_ARCH_CAPABILITIES, ia32_cap);
>> +
>> +	/* Rogue Data Cache Load? No! */
>> +	if (ia32_cap & ARCH_CAP_RDCL_NO)
>> +		return false;
>> +
>> +	return true;
>> +}
> 
> Feel free to add my ack on this.  It looks fine to me.  I'll test and
> submit any necessary fixes once I actually get a system that has this bit.

Well, that was fast.  A system supporting the RDCL_NO bit booted this
code.  It reported not being affected by meltdown:

foo:/sys/devices/system/cpu/vulnerabilities/ # grep . *
meltdown:Not affected
spectre_v1:Vulnerable
spectre_v2:Vulnerable: Minimal generic ASM retpoline
foo:/sys/devices/system/cpu/vulnerabilities/ #