linux-kernel - Re: [PATCH] x86/retpoline/entry: Disable the entire SYSCALL64 fast path with retpolines on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALCETrXYdiG87cL1n3O8v+OSM9Fc6meNXqau4qSv+5iUV=aEeg@mail.gmail.com>
Date:   Thu, 25 Jan 2018 13:53:09 -0800
From:   Andy Lutomirski <luto@...nel.org>
To:     Dan Williams <dan.j.williams@...el.com>
Cc:     Andy Lutomirski <luto@...nel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        "the arch/x86 maintainers" <x86@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alan Cox <alan@...ux.intel.com>, Jann Horn <jannh@...gle.com>,
        Samuel Neves <samuel.c.p.neves@...il.com>,
        Kernel Hardening <kernel-hardening@...ts.openwall.com>,
        Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH] x86/retpoline/entry: Disable the entire SYSCALL64 fast
 path with retpolines on

On Thu, Jan 25, 2018 at 1:39 PM, Dan Williams <dan.j.williams@...el.com> wrote:
> On Thu, Jan 25, 2018 at 1:31 PM, Andy Lutomirski <luto@...nel.org> wrote:
>> On Thu, Jan 25, 2018 at 1:20 PM, Linus Torvalds
>> <torvalds@...ux-foundation.org> wrote:
>>> On Thu, Jan 25, 2018 at 1:08 PM, Andy Lutomirski <luto@...nel.org> wrote:
>>>>
>>>> With retpoline, the retpoline in the trampoline sucks.  I don't need
>>>> perf for that -- I've benchmarked it both ways.  It sucks.  I'll fix
>>>> it, but it'll be kind of complicated.
>>>
>>> Ahh, I'd forgotten about that (and obviously didn't see it in the profiles).
>>>
>>> But yeah, that is fixable even if it does require a page per CPU. Or
>>> did you have some clever scheme in mind?
>>
>> Nothing clever.  I was going to see if I could get actual
>> binutils-generated relocations to work in the trampoline.  We already
>> have code to parse ELF relocations and turn them into a simple table,
>> and it shouldn't be *that* hard to run a separate pass on the entry
>> trampoline.
>>
>> Another potentially useful if rather minor optimization would be to
>> rejigger the SYSCALL_DEFINE macros a bit.  Currently we treat all
>> syscalls like this:
>>
>> long func(long arg0, long arg1, long arg2, long arg3, long arg4, long arg5);
>>
>> I wonder if we'd be better off doing:
>>
>> long func(const struct pt_regs *regs);
>>
>> and autogenerating:
>>
>> static long SyS_read(const struct pt_regs *regs)
>> {
>>    return sys_reg(regs->di, ...);
>> }
>
> If you're rejiggering, can we also put in a mechanism for detecting
> which registers to clear so that userspace can't inject useful values
> into speculation paths?
>
> https://patchwork.kernel.org/patch/10153753/

My SYSCALL_DEFINE rejigger suggestion up-thread does this for free as
a side effect.

That being said, I think this would be more accurately characterized
as "so that userspace has a somewhat harder time injecting useful
values into speculation paths".