linux-kernel - Re: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI whitelist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180125230239.GA3736@fury>
Date:   Thu, 25 Jan 2018 15:02:39 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Alexander Abrosimov <alexander.n.abrosimov@...il.com>
Cc:     Matthew Garrett <mjg59@...f.ucam.org>,
        Pali Rohár <pali.rohar@...il.com>,
        Mario Limonciello <mario.limonciello@...l.com>,
        Andy Shevchenko <andy@...radead.org>,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] platform/x86: dell-laptop: Add 2-in-1 devices to the DMI
 whitelist

On Fri, Jan 26, 2018 at 01:48:57AM +0300, Alexander Abrosimov wrote:
> SMBIOS 3.0.0 Specification introduced new Chassis Types field values for
> 2-in-1 devices like tablets, convertibles and detachables. Dell's
> Inspiron 2-in-1 and XPS 2-in-1 fall into this category and they have to
> be added to the DMI whitelist, so rfkill and backlight can be controlled
> for them as for other laptops.
> 
> Signed-off-by: Alexander Abrosimov <alexander.n.abrosimov@...il.com>

Thanks Alexander. Looks good - just going to give Pali and +Mario a chance to
respond before merging...

> ---
>  drivers/platform/x86/dell-laptop.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c
> index cd4725e7e0b5..23fc94d70ea1 100644
> --- a/drivers/platform/x86/dell-laptop.c
> +++ b/drivers/platform/x86/dell-laptop.c
> @@ -110,6 +110,24 @@ static const struct dmi_system_id dell_device_table[] __initconst = {
>  		},
>  	},
>  	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_CHASSIS_TYPE, "30"), /*Tablet*/
> +		},
> +	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_CHASSIS_TYPE, "31"), /*Convertible*/
> +		},
> +	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_CHASSIS_TYPE, "32"), /*Detachable*/
> +		},
> +	},
> +	{
>  		.ident = "Dell Computer Corporation",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "Dell Computer Corporation"),
> -- 
> 2.13.6
> 
> 

-- 
Darren Hart
VMware Open Source Technology Center