linux-kernel - Re: [PATCH v2] NTB: ntb_perf: fix cast to restricted _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180125041353.GA9887@kudzu.us>
Date:   Wed, 24 Jan 2018 23:13:54 -0500
From:   Jon Mason <jdmason@...zu.us>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Serge Semin <fancer.lancer@...il.com>,
        Dave Jiang <dave.jiang@...el.com>, allenbh@...il.com,
        "Hook, Gary" <gary.hook@....com>, Sergey.Semin@...latforms.ru,
        linux-ntb@...glegroups.com,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] NTB: ntb_perf: fix cast to restricted __le32

On Wed, Jan 24, 2018 at 09:07:26AM +0100, Arnd Bergmann wrote:
> On Wed, Jan 24, 2018 at 8:48 AM, Serge Semin <fancer.lancer@...il.com> wrote:
> > Sparse is whining about the u32 and __le32 mixed usage in the driver
> >
> > drivers/ntb/test/ntb_perf.c:288:21: warning: cast to restricted __le32
> > drivers/ntb/test/ntb_perf.c:295:37: warning: incorrect type in argument 4 (different base types)
> > drivers/ntb/test/ntb_perf.c:295:37:    expected unsigned int [unsigned] [usertype] val
> > drivers/ntb/test/ntb_perf.c:295:37:    got restricted __le32 [usertype] <noident>
> > ...
> >
> > NTB hardware drivers shall accept CPU-endian data and translate it to
> > the portable formate by internal means, so the explicit conversions
> > are not necessary before Scratchpad/Messages API usage anymore.
> >
> > Fixes: b83003b3fdc1 ("NTB: ntb_perf: Add full multi-port NTB API support")
> > Signed-off-by: Serge Semin <fancer.lancer@...il.com>
> 
> Looks good to me,
> 
> Acked-by: Arnd Bergmann <arnd@...db.de>

Applied to my ntb-next branch.  Thanks for all of the help on this.

Thanks,
Jon