linux-kernel - RE: [PATCH] ARM: dts: imx6sx: add pu power domain support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM3PR04MB1315462173409260DDEB4C3DF5E00@AM3PR04MB1315.eurprd04.prod.outlook.com>
Date:   Fri, 26 Jan 2018 06:32:23 +0000
From:   Anson Huang <anson.huang@....com>
To:     Dong Aisheng <dongas86@...il.com>
CC:     "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "A.s. Dong" <aisheng.dong@....com>,
        "mark.rutland@....com" <mark.rutland@....com>,
        "linux@...linux.org.uk" <linux@...linux.org.uk>,
        dl-linux-imx <linux-imx@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ARM: dts: imx6sx: add pu power domain support



-----Original Message-----
From: Dong Aisheng [mailto:dongas86@...il.com] 
Sent: 2018年1月25日 23:30
To: Anson Huang <anson.huang@....com>
Cc: shawnguo@...nel.org; kernel@...gutronix.de; Fabio Estevam <fabio.estevam@....com>; robh+dt@...nel.org; A.s. Dong <aisheng.dong@....com>; mark.rutland@....com; linux@...linux.org.uk; dl-linux-imx <linux-imx@....com>; linux-arm-kernel@...ts.infradead.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6sx: add pu power domain support

On Tue, Jan 23, 2018 at 11:12:23PM +0800, Anson Huang wrote:
> Add PU power domain support, GPU is the only module inside PU power 
> domain, and PU power is supplied by LDO_SOC.
> 
> Signed-off-by: Anson Huang <Anson.Huang@....com>
> ---
>  arch/arm/boot/dts/imx6sx.dtsi | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6sx.dtsi 
> b/arch/arm/boot/dts/imx6sx.dtsi index fd78793..42ef4c6 100644
> --- a/arch/arm/boot/dts/imx6sx.dtsi
> +++ b/arch/arm/boot/dts/imx6sx.dtsi
> @@ -188,6 +188,7 @@
>  				 <&clks IMX6SX_CLK_GPU>,
>  				 <&clks IMX6SX_CLK_GPU>;
>  			clock-names = "bus", "core", "shader";
> +			power-domains = <&pd_pu>;
>  		};
>  
>  		dma_apbh: dma-apbh@...4000 {
> @@ -767,6 +768,13 @@
>  					#address-cells = <1>;
>  					#size-cells = <0>;
>  
> +					pd_pu: power-domain@1 {
> +						reg = <1>;
> +						#power-domain-cells = <0>;
> +						power-supply = <&reg_soc>;

I wonder we may not need this as it's a non-stop domain just like we did for arm domain, right?

Otherwise, the patch looks fine to me.

Acked-by: Dong Aisheng <aisheng.dong@....com>

No, this domain can be power gated, there is an internal power gate in GPC, just the input
power can NOT be disabled. So there might be some leakage in this domain, but power still
can be saved a lot if internal power gate is off.

Anson.

Regards
Dong Aisheng

> +						clocks = <&clks IMX6SX_CLK_GPU>;
> +					};
> +
>  					pd_pci: power-domain@3 {
>  						reg = <3>;
>  						#power-domain-cells = <0>;
> --
> 2.7.4
>