linux-kernel - Re: [PATCH] platform/x86: dell-smbios: Correct notation for filtering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 26 Jan 2018 10:04:26 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Mario Limonciello <mario.limonciello@...l.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH] platform/x86: dell-smbios: Correct notation for filtering

On Fri, Jan 5, 2018 at 4:56 PM, Mario Limonciello
<mario.limonciello@...l.com> wrote:
> The class/select were mistakingly put into octal notation but

mistakenly

> intended to be in decimal notation.
>
> Suggest-by: Pali Rohar <pali.rohar@...il.com>

Suggested-by:

> Signed-off-by: Mario Limonciello <mario.limonciello@...l.com>

I have fixed above and pushed to my review and testing queue, thanks!

> ---
>  drivers/platform/x86/dell-smbios.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c
> index 6a60db5..8541cde 100644
> --- a/drivers/platform/x86/dell-smbios.c
> +++ b/drivers/platform/x86/dell-smbios.c
> @@ -65,10 +65,10 @@ static struct smbios_call call_whitelist[] = {
>
>  /* calls that are explicitly blacklisted */
>  static struct smbios_call call_blacklist[] = {
> -       {0x0000, 01, 07}, /* manufacturing use */
> -       {0x0000, 06, 05}, /* manufacturing use */
> -       {0x0000, 11, 03}, /* write once */
> -       {0x0000, 11, 07}, /* write once */
> +       {0x0000,  1,  7}, /* manufacturing use */
> +       {0x0000,  6,  5}, /* manufacturing use */
> +       {0x0000, 11,  3}, /* write once */
> +       {0x0000, 11,  7}, /* write once */
>         {0x0000, 11, 11}, /* write once */
>         {0x0000, 19, -1}, /* diagnostics */
>         /* handled by kernel: dell-laptop */
> --
> 2.7.4
>



-- 
With Best Regards,
Andy Shevchenko