[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <85ab024b-6af2-8b58-f9e8-7920d132cefb@linux.vnet.ibm.com>
Date: Fri, 26 Jan 2018 11:26:19 -0500
From: Farhan Ali <alifm@...ux.vnet.ibm.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-s390 <linux-s390@...r.kernel.org>,
Linux Fbdev development list <linux-fbdev@...r.kernel.org>,
Martin Schwidefsky <schwidefsky@...ibm.com>,
Christian Borntraeger <borntraeger@...ibm.com>,
Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
Tomi Valkeinen <tomi.valkeinen@...com>
Subject: Re: [PATCH v1 0/2] Kconfig changes to enable Graphics Support for
S390
On 01/26/2018 10:06 AM, Geert Uytterhoeven wrote:
>> Hi Geert,
>>
>> I wasn't sure what would be the best ordering since we would never hit the
>> issue if patch 1 didn't exist. But if the preference is to invert the
>> ordering of patches, then I will change the ordering.
> Alternatively, you can combine two patches into a single patch, which
> moves the dependency from the whole subsystem to the driver that needs
> it (are there more?).
>
> Gr{oetje,eeting}s,
>
> Geert
I like the idea of combining both patches into one.
There are other fbdev drivers that use iomem (found by grepping for
"devm_ioremap_resource"):
CONFIG_FB_S3C (s3c-fb.c)
CONFIG_FB_CLPS711X (clps711x-fb.c)
CONFIG_FB_JZ4740 (jz4740_fb.c)
CONFIG_FB_DA8XX (da8xx-fb.c)
CONFIG_FB_WM8505 (wm8505fb.c)
CONFIG_OMAP2_VRFB (omap2/omapfb/vrfb.c)
CONFIG_FB_OMAP2 (omap2/omapfb/dss/*
CONFIG_FB_MXS (mxsfb.c)
CONFIG_PXA3XX_GCU (pxa3xx-gcu.c)
CONFIG_FB_XILINX (xilinxfb.c)
All of these are already fenced off by architecture dependencies (which
I am assuming enables CONFIG_HAS_IOMEM by default). If we want to be
cautious I can add HAS_IOMEM dependency for all of them.
Thanks
Farhan
Powered by blists - more mailing lists