linux-kernel - Re: [PATCH] x86/cpufeatures: Cleanup AMD speculation feature bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1516992318.30244.271.camel@infradead.org>
Date:   Fri, 26 Jan 2018 18:45:18 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Borislav Petkov <bp@...en8.de>, x86-ml <x86@...nel.org>
Cc:     linux-tip-commits@...r.kernel.org, hpa@...or.com,
        gregkh@...uxfoundation.org, tglx@...utronix.de,
        thomas.lendacky@....com, linux-kernel@...r.kernel.org,
        mingo@...nel.org
Subject: Re: [PATCH] x86/cpufeatures: Cleanup AMD speculation feature bits

On Fri, 2018-01-26 at 19:41 +0100, Borislav Petkov wrote:
> +#define X86_FEATURE_AMD_IBPB           (13*32+12) /* "" Indirect Branch Prediction Barrier MSR */

Stray quotes.

> +#define X86_FEATURE_IBRS               (13*32+14) /* Indirect Branch Restricted Speculation */

Please don't call it that. Call it X86_FEATURE_AMD_IBRS and leave
X86_FEATURE_IBRS to parallel X86_FEATURE_IBPB as the *software* bit
which is vendor-independent.

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5213 bytes)