linux-kernel - [PATCH] Fix compile warning with ATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5be87d13-f9a0-5b12-ced4-cec5d6394da1@huawei.com>
Date:   Fri, 26 Jan 2018 11:21:49 +0800
From:   "dongbo (E)" <dongbo4@...wei.com>
To:     <tj@...nel.org>
CC:     <linux-ide@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>
Subject: [PATCH] Fix compile warning with ATA_DEBUG enabled

From: Dong Bo <dongbo4@...wei.com>

This fixs the following comile warnings with ATA_DEBUG enabled,
which detected by Linaro GCC 5.2-2015.11:

In file included from ./include/linux/printk.h:7:0,
                 from ./include/linux/kernel.h:14,
                 from ./include/asm-generic/bug.h:16,
                 from ./arch/arm64/include/asm/bug.h:37,
                 from ./include/linux/bug.h:5,
                 from ./include/linux/mmdebug.h:5,
                 from ./include/linux/gfp.h:5,
                 from ./include/linux/slab.h:15,
                 from drivers/ata/libata-scsi.c:36:
drivers/ata/libata-scsi.c: In function 'ata_scsi_dump_cdb':
./include/linux/kern_levels.h:5:18: warning: format '%d' expects
argument of type 'int', but argument 6 has type 'u64 {aka long
 long unsigned int}' [-Wformat=]
 #define KERN_SOH "\001"  /* ASCII Start Of Header */
                  ^
./include/linux/kern_levels.h:11:18: note: in expansion of macro
'KERN_SOH'
 #define KERN_ERR KERN_SOH "3" /* error conditions */
                  ^
./include/linux/libata.h:65:38: note: in expansion of macro 'KERN_ERR'
 #define DPRINTK(fmt, args...) printk(KERN_ERR "%s: " fmt,
				__func__, ## args)
                                      ^
drivers/ata/libata-scsi.c:4284:2: note: in expansion of macro 'DPRINTK'
  DPRINTK("CDB (%u:%d,%d,%d) %9ph\n",
  ^

Signed-off-by: Dong Bo <dongbo4@...wei.com>
---
 drivers/ata/libata-scsi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 66be961..214ecb6 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -4282,7 +4282,7 @@ static inline void ata_scsi_dump_cdb(struct ata_port *ap,
 #ifdef ATA_DEBUG
 	struct scsi_device *scsidev = cmd->device;
 -	DPRINTK("CDB (%u:%d,%d,%d) %9ph\n",
+	DPRINTK("CDB (%u:%u,%u,%lld) %9ph\n",
 		ap->print_id,
 		scsidev->channel, scsidev->id, scsidev->lun,
 		cmd->cmnd);
-- 
1.9.1


.