linux-kernel - Re: [PATCH] x86/cpufeatures: Cleanup AMD speculation feature bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7094ed9b-40f7-ba2b-55a6-cc5ab0b06bb9@amd.com>
Date:   Fri, 26 Jan 2018 15:06:20 -0600
From:   Tom Lendacky <thomas.lendacky@....com>
To:     Borislav Petkov <bp@...en8.de>,
        David Woodhouse <dwmw2@...radead.org>
Cc:     x86-ml <x86@...nel.org>, linux-tip-commits@...r.kernel.org,
        hpa@...or.com, gregkh@...uxfoundation.org, tglx@...utronix.de,
        linux-kernel@...r.kernel.org, mingo@...nel.org
Subject: Re: [PATCH] x86/cpufeatures: Cleanup AMD speculation feature bits

On 1/26/2018 12:49 PM, Borislav Petkov wrote:
> On Fri, Jan 26, 2018 at 06:45:18PM +0000, David Woodhouse wrote:
>> On Fri, 2018-01-26 at 19:41 +0100, Borislav Petkov wrote:
>>> +#define X86_FEATURE_AMD_IBPB           (13*32+12) /* "" Indirect Branch Prediction Barrier MSR */
>>
>> Stray quotes.
> 
> No no, those quotes are magical. :)
> 
> They don't show the string in /proc/cpuinfo, see arch/x86/kernel/cpu/mkcapflags.sh
> 
>>> +#define X86_FEATURE_IBRS               (13*32+14) /* Indirect Branch Restricted Speculation */
>>
>> Please don't call it that. Call it X86_FEATURE_AMD_IBRS and leave
>> X86_FEATURE_IBRS to parallel X86_FEATURE_IBPB as the *software* bit
>> which is vendor-independent.
> 
> Do we have a X86_FEATURE_IBRS bit?
> 
> If so, then this bit should become
> 
> #define X86_FEATURE_AMD_IBRS      (13*32+14) /* "" Speculation Control MSR only (AMD) */
> 
> *with* the magic quotes.

So I like the idea of AMD_IBRS/AMD_IBPB/AMD_STIBP and then use the magic
quotes as appropriate.  We could probably use the magic quotes on
AMD_STIBP and set X86_FEATURE_STIBP when we see X86_FEATURE_AMD_STIBP.

Just my two cents.

Thanks,
Tom

>