linux-kernel - Re: [PATCH 6/8] kprobes/arm64: Fix %p uses in error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 26 Jan 2018 14:40:53 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Will Deacon <will.deacon@....com>
Cc:     catalin.marinas@....com, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Ananth N Mavinakayanahalli <ananth@...ibm.com>,
        Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jon Medhurst <tixy@...aro.org>, Arnd Bergmann <arnd@...db.de>,
        David Howells <dhowells@...hat.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        "Tobin C . Harding" <me@...in.cc>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH 6/8] kprobes/arm64: Fix %p uses in error messages

On Thu, 25 Jan 2018 16:42:31 +0000
Will Deacon <will.deacon@....com> wrote:

> On Thu, Jan 25, 2018 at 02:29:32PM +0900, Masami Hiramatsu wrote:
> > Fix %p uses in error messages by removing it because
> > those are redundant or meaningless.
> > 
> > Signed-off-by: Masami Hiramatsu <mhiramat@...nel.org>
> > ---
> >  arch/arm64/kernel/probes/kprobes.c |    4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> Acked-by: Will Deacon <will.deacon@....com>
> 
> I guess Catalin can just pick this one up via arm64.

OK, thanks!

> 
> Will
> 
> > diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c
> > index d849d9804011..34f78d07a068 100644
> > --- a/arch/arm64/kernel/probes/kprobes.c
> > +++ b/arch/arm64/kernel/probes/kprobes.c
> > @@ -275,7 +275,7 @@ static int __kprobes reenter_kprobe(struct kprobe *p,
> >  		break;
> >  	case KPROBE_HIT_SS:
> >  	case KPROBE_REENTER:
> > -		pr_warn("Unrecoverable kprobe detected at %p.\n", p->addr);
> > +		pr_warn("Unrecoverable kprobe detected.\n");
> >  		dump_kprobe(p);
> >  		BUG();
> >  		break;
> > @@ -521,7 +521,7 @@ int __kprobes longjmp_break_handler(struct kprobe *p, struct pt_regs *regs)
> >  		    (struct pt_regs *)kcb->jprobe_saved_regs.sp;
> >  		pr_err("current sp %lx does not match saved sp %lx\n",
> >  		       orig_sp, stack_addr);
> > -		pr_err("Saved registers for jprobe %p\n", jp);
> > +		pr_err("Saved registers for jprobe\n");
> >  		__show_regs(saved_regs);
> >  		pr_err("Current registers\n");
> >  		__show_regs(regs);
> > 


-- 
Masami Hiramatsu <mhiramat@...nel.org>