linux-kernel - Re: [PATCH] firmware: tegra: adjust tested variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c6c4a51-93d4-04b6-db53-5ef582db97c8@kapsi.fi>
Date:   Sat, 27 Jan 2018 17:03:12 +0200
From:   Mikko Perttunen <cyndis@...si.fi>
To:     Julia Lawall <Julia.Lawall@...6.fr>,
        Thierry Reding <thierry.reding@...il.com>
Cc:     kernel-janitors@...r.kernel.org,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: tegra: adjust tested variable

Reviewed-by: Mikko Perttunen <mperttunen@...dia.com>

On 01/27/2018 04:28 PM, Julia Lawall wrote:
> Check the variable that was most recently initialized.
> 
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression x, y, f, g, e, m;
> statement S1,S2,S3,S4;
> @@
> 
> x = f(...);
> if (\(<+...x...+>\&e\)) S1 else S2
> (
> x = g(...);
> |
> m = g(...,&x,...);
> |
> y = g(...);
> *if (e)
>   S3 else S4
> )
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
>   drivers/firmware/tegra/bpmp.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/tegra/bpmp.c b/drivers/firmware/tegra/bpmp.c
> index a7f461f..96362b5 100644
> --- a/drivers/firmware/tegra/bpmp.c
> +++ b/drivers/firmware/tegra/bpmp.c
> @@ -732,7 +732,7 @@ static int tegra_bpmp_probe(struct platform_device *pdev)
>   	}
>   
>   	bpmp->rx.virt = gen_pool_dma_alloc(bpmp->rx.pool, 4096, &bpmp->rx.phys);
> -	if (!bpmp->rx.pool) {
> +	if (!bpmp->rx.virt) {
>   		dev_err(&pdev->dev, "failed to allocate from RX pool\n");
>   		err = -ENOMEM;
>   		goto free_tx;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>