linux-kernel - Re: [PATCH v2 3/4] openrisc: Use the new MULTI_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180127031318.GA30895@lianli.shorne-pla.net>
Date:   Sat, 27 Jan 2018 12:13:18 +0900
From:   Stafford Horne <shorne@...il.com>
To:     Christoph Hellwig <hch@...radead.org>
Cc:     Palmer Dabbelt <palmer@...ive.com>, linux@...linux.org.uk,
        catalin.marinas@....com, Will Deacon <will.deacon@....com>,
        jonas@...thpole.se, stefan.kristiansson@...nalahti.fi,
        tglx@...utronix.de, Arnd Bergmann <arnd@...db.de>,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
        patches@...ups.riscv.org
Subject: Re: [PATCH v2 3/4] openrisc: Use the new MULTI_IRQ_HANDLER

On Wed, Jan 24, 2018 at 11:46:19PM -0800, Christoph Hellwig wrote:
> On Wed, Jan 24, 2018 at 07:07:55PM -0800, Palmer Dabbelt wrote:
> > It appears that openrisc copied arm64's MULTI_IRQ_HANDLER code (which
> > came from arm).  I wanted to make this generic so I could use it in the
> > RISC-V port.  This patch converts the openrisc code to use the generic
> > version.
> 
> Note that openriscv overrides previous handle_arch_irq assignments.
> We'll need to know from the openrisc folks if that was intentional.
> 
> Otherwise this looks fine to me.

This looks fine to me too.  We only assign the handle_arch_irq one time.  I
think not protecting against overrides was an oversight in the original
implementation.

Acked-by: Stafford Horne <shorne@...il.com>

-Stafford