linux-kernel - Re: [PATCH] USB: wusbcore: remove redundant re-assignment to pointer 'dev'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180127051624.GA11128@localhost>
Date:   Sat, 27 Jan 2018 16:16:24 +1100
From:   Johan Hovold <johan@...nel.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        Johan Hovold <johan@...nel.org>, linux-usb@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: wusbcore: remove redundant re-assignment to pointer
 'dev'

On Fri, Jan 26, 2018 at 03:07:12PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Pointer dev is initialized and then re-assigned with the same value
> a little later, hence the second assignment is redundant and can be
> removed.
> 
> Cleans up clang warning:
> drivers/usb/wusbcore/wa-nep.c:88:17: warning: Value stored to 'dev'
> during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Johan Hovold <johan@...nel.org>