linux-kernel - Re: [PATCH v2 2/5] powerpc/32: Fix hugepage allocation on 8xx at hint address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87inbn3an4.fsf@concordia.ellerman.id.au>
Date:   Sat, 27 Jan 2018 20:37:35 +1100
From:   Michael Ellerman <mpe@...erman.id.au>
To:     "Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com>,
        Christophe Leroy <christophe.leroy@....fr>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Paul Mackerras <paulus@...ba.org>,
        Scott Wood <oss@...error.net>
Cc:     linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH v2 2/5] powerpc/32: Fix hugepage allocation on 8xx at hint address

"Aneesh Kumar K.V" <aneesh.kumar@...ux.vnet.ibm.com> writes:

> Christophe Leroy <christophe.leroy@....fr> writes:
>
>> On the 8xx, the page size is set in the PMD entry and applies to
>> all pages of the page table pointed by the said PMD entry.
>>
...
>> diff --git a/arch/powerpc/mm/hugetlbpage.c b/arch/powerpc/mm/hugetlbpage.c
>> index a9b9083c5e49..79e1378ee303 100644
>> --- a/arch/powerpc/mm/hugetlbpage.c
>> +++ b/arch/powerpc/mm/hugetlbpage.c
>> @@ -553,9 +553,11 @@ unsigned long hugetlb_get_unmapped_area(struct file *file, unsigned long addr,
>>  	struct hstate *hstate = hstate_file(file);
>>  	int mmu_psize = shift_to_mmu_psize(huge_page_shift(hstate));
>>  
>> +#ifdef CONFIG_PPC_RADIX_MMU
>>  	if (radix_enabled())
>>  		return radix__hugetlb_get_unmapped_area(file, addr, len,
>>  						       pgoff, flags);
>> +#endif
>
> if (0) didn't remove the following radix__hugetlb_get_unmapped_area for
> you? 

It will remove the call, but you still need at least a prototype, or an
empty static inline.

cheers