linux-kernel - Re: [PATCH v18 03/10] video: backlight: Add of_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VcM3-D+kwzzGutoFXo9-WHK20TW=STqMku5mqcUSDCDyw@mail.gmail.com>
Date:   Sun, 28 Jan 2018 19:15:08 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Meghana Madhyastha <meghana.madhyastha@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Noralf Trønnes <noralf@...nnes.org>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Sean Paul <seanpaul@...omium.org>,
        dri-devel@...ts.freedesktop.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v18 03/10] video: backlight: Add of_find_backlight helper
 in backlight.c

On Mon, Jan 22, 2018 at 4:51 PM, Meghana Madhyastha
<meghana.madhyastha@...il.com> wrote:
> Add of_find_backlight, a helper function which is a generic version
> of tinydrm_of_find_backlight that can be used by other drivers to avoid
> repetition of code and simplify things.

> +struct backlight_device *of_find_backlight(struct device *dev)

It looks strange that of_ prefixed function takes struct device
instead of struct device_node.

-- 
With Best Regards,
Andy Shevchenko