linux-kernel - [PATCH] btrfs: fix err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 29 Jan 2018 02:50:10 +0800
From:   kbuild test robot <fengguang.wu@...el.com>
To:     Anand Jain <anand.jain@...cle.com>
Cc:     kbuild-all@...org, David Sterba <dsterba@...e.com>,
        Chris Mason <chris.mason@...ionio.com>,
        Chris Mason <clm@...com>, Josef Bacik <jbacik@...com>,
        linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] btrfs: fix err_cast.cocci warnings

From: Fengguang Wu <fengguang.wu@...el.com>

fs/btrfs/volumes.c:742:10-17: WARNING: ERR_CAST can be used with fs_devices


 Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...))

Generated by: scripts/coccinelle/api/err_cast.cocci

Fixes: bf155c98d312 ("btrfs: get device pointer from device_list_add()")
CC: Anand Jain <anand.jain@...cle.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

 volumes.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/btrfs/volumes.c
+++ b/fs/btrfs/volumes.c
@@ -739,7 +739,7 @@ static noinline struct btrfs_device *dev
 	if (!fs_devices) {
 		fs_devices = alloc_fs_devices(disk_super->fsid);
 		if (IS_ERR(fs_devices))
-			return ERR_PTR(PTR_ERR(fs_devices));
+			return ERR_CAST(fs_devices);
 
 		list_add(&fs_devices->list, &fs_uuids);