linux-kernel - Re: [PATCH] drm/radeon: adjust tested variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f6ee63cc-0d2e-d314-1621-dd9045970ada@amd.com>
Date:   Sun, 28 Jan 2018 14:03:31 +0100
From:   Christian König <christian.koenig@....com>
To:     Julia Lawall <Julia.Lawall@...6.fr>,
        Alex Deucher <alexander.deucher@....com>
Cc:     kernel-janitors@...r.kernel.org,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/radeon: adjust tested variable

Am 27.01.2018 um 15:28 schrieb Julia Lawall:
> Check the variable that was most recently initialized.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression x, y, f, g, e, m;
> statement S1,S2,S3,S4;
> @@
>
> x = f(...);
> if (\(<+...x...+>\&e\)) S1 else S2
> (
> x = g(...);
> |
> m = g(...,&x,...);
> |
> y = g(...);
> *if (e)
>   S3 else S4
> )
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>

Good catch, added my rb and pushed it into our to-be-upstreamed branch.

Thanks,
Christian.

>
> ---
>   drivers/gpu/drm/radeon/radeon_uvd.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_uvd.c b/drivers/gpu/drm/radeon/radeon_uvd.c
> index d34d1cf..95f4db7 100644
> --- a/drivers/gpu/drm/radeon/radeon_uvd.c
> +++ b/drivers/gpu/drm/radeon/radeon_uvd.c
> @@ -995,7 +995,7 @@ int radeon_uvd_calc_upll_dividers(struct radeon_device *rdev,
>   		/* calc dclk divider with current vco freq */
>   		dclk_div = radeon_uvd_calc_upll_post_div(vco_freq, dclk,
>   							 pd_min, pd_even);
> -		if (vclk_div > pd_max)
> +		if (dclk_div > pd_max)
>   			break; /* vco is too big, it has to stop */
>   
>   		/* calc score with current vco freq */
>